Add Glacier2/session Demo to Java #647

InsertCreativityHere · 2025-10-17T19:22:47Z

This PR won't work until the slice-tools snapshots pulls in this fix tonight: zeroc-ice/ice#4561

This reverts commit 4f5e357.

Copilot

Pull Request Overview

This PR adds a new Glacier2/session demo to the Java demos directory. The demo illustrates how to implement and configure a custom Glacier2 Session Manager and demonstrates the use of default servants.

Key changes:

Added a complete Java implementation of the Glacier2/session demo with client and server components
Updated the Java README.md to include entries for the new Glacier2 Session demo and corrected the table formatting
Fixed minor documentation inconsistencies in the C# version of the same demo

Reviewed Changes

Copilot reviewed 21 out of 23 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
java/README.md	Added table entries for the new Glacier2/Session demo and fixed table alignment
java/Glacier2/session/slice/PokeBox.ice	Defined Slice interfaces for the Pokemon application (PokeBox and PokeSession)
java/Glacier2/session/settings.gradle.kts	Configured Gradle settings with Maven snapshot repositories for nightly builds
java/Glacier2/session/server/src/main/java/com/example/glacier2/session/server/*	Implemented server-side components including SessionManager, SharedPokeBox, and storage interfaces
java/Glacier2/session/server/build.gradle.kts	Configured server build with Ice and Glacier2 dependencies
java/Glacier2/session/gradlew.bat	Added Gradle wrapper script for Windows
java/Glacier2/session/gradlew	Added Gradle wrapper script for Unix-like systems
java/Glacier2/session/gradle/wrapper/gradle-wrapper.properties	Configured Gradle wrapper to use version 8.12.1
java/Glacier2/session/config.glacier2	Configured Glacier2 router settings including endpoints and session manager
java/Glacier2/session/client/src/main/java/com/example/glacier2/session/client/Client.java	Implemented client application demonstrating session creation and Pokemon management
java/Glacier2/session/client/build.gradle.kts	Configured client build with Ice and Glacier2 dependencies
java/Glacier2/session/README.md	Added comprehensive documentation for the demo including build and run instructions
java/Glacier2/session/.gitignore	Added standard Gradle ignore patterns
csharp/Glacier2/Session/Server/IPokeStore.cs	Fixed documentation wording from "for" to "of"
csharp/Glacier2/Session/Client/Program.cs	Corrected comment to specify "Glacier2 router" instead of "Glacier router"

...Glacier2/session/server/src/main/java/com/example/glacier2/session/server/SharedPokeBox.java

…2/session/server/SharedPokeBox.java Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 21 out of 23 changed files in this pull request and generated 1 comment.

java/Glacier2/session/slice/PokeBox.ice

externl · 2025-10-20T18:10:30Z

...ier2/session/server/src/main/java/com/example/glacier2/session/server/InMemoryPokeStore.java

+class InMemoryPokeStore implements PokeStore {
+    private final Map<String, List<String>> _store = new HashMap<>();
+
+    public void saveCollection(String userId, List<String> pokemon) {


Missing @Override in this file?

bernardnormier · 2025-10-20T20:35:09Z

csharp/Glacier2/Session/Server/IPokeStore.cs

 {
    /// <summary>Saves the Pokémon collection for a specific user.</summary>
-    /// <param name="userId">The user ID.</param>
+    /// <param name="userId">The user's ID.</param>


I would keep user ID. It's a common term, much more common than user's ID.

I put it back how it was. The apostrophe made it less grammatically ambiguous though.

bernardnormier · 2025-10-20T20:41:33Z

...er2/session/server/src/main/java/com/example/glacier2/session/server/DefaultPokeSession.java

+    /**
+     * A proxy to the SessionControl object hosted by the Glacier2 router.
+     * This proxy allows us to control the Glacier2 session, in particular to destroy it.
+     * In this demo, that's the only per-session state maintained by {@code DefaultPokeSession}.


Should this be @link instead of @code?

Or just maintained by this class. This links to self are not very useful.

I agree 'this class' is simpler.

bernardnormier · 2025-10-20T20:46:52Z

...lacier2/session/server/src/main/java/com/example/glacier2/session/server/SessionManager.java

+import java.util.Map;
+
+/**
+ * {@code SessionManager} is an Ice servant that implements Slice interface 'Glacier2::SessionManager'.


I'd remove the @code.

It's a Java convention that when you use a class' name in it's own description, it should use code formatting.
We don't follow that convention very well, but that doesn't mean now is a bad time to start.

pepone · 2025-10-21T08:13:20Z

java/Glacier2/session/server/src/main/java/com/example/glacier2/session/server/PokeStore.java

+     * @return the saved Pokémon collection, or {@code null} if no collection was saved for {@code userId}.
+     *     The returned list is immutable. Attempting to modify it will throw an UnsupportedOperationException.
+     */
+    List<String> retrieveCollection(String userId);


I guess this a shortcoming of the JDK that doesn't provide an immutable list interface. Here we are documenting the expected behavior of the implementation but we cannot enforce it.

Yes, it's definitely a little lame. I spent some time looking into if there's any kind of enforcement, but there short of passing the internal List wrapper type, there just isn't.

Even worse, when you see a List, you don't even know if its safe to mutate or not. Not a very elegant design.

pepone · 2025-10-21T08:16:05Z

...Glacier2/session/server/src/main/java/com/example/glacier2/session/server/SharedPokeBox.java

+
+    // Retrieve the Pokémon collection for the user associated with the current session.
+    @Override
+    public String[] getInventory(Current current) {


What about mapping the collection to a List in the Slice file and avoid this conversion.

Yes, that removed the distracting conversion code. Very nice!

pepone · 2025-10-21T08:16:55Z

...Glacier2/session/server/src/main/java/com/example/glacier2/session/server/SharedPokeBox.java

+    public void caught(String[] pokemon, Current current) {
+        String userId = getUserId(current);
+
+        List<String> newPokemon = new ArrayList<>(Arrays.asList(pokemon));


Here too, we can map the input parameter to a List.

Copilot

Pull Request Overview

Copilot reviewed 21 out of 23 changed files in this pull request and generated no new comments.

InsertCreativityHere added 7 commits October 16, 2025 11:07

Small cleanup to Java CtrlC hooks.

4f5e357

Added skeleton of the new Java Glacier2/Session demo.

66221b0

Ported the client side logic.

44b3854

Written out the server.

0160b0d

Fixes.

b8f18e4

More fixes.

6bd93ad

Revert "Small cleanup to Java CtrlC hooks."

95cfba2

This reverts commit 4f5e357.

InsertCreativityHere requested a review from Copilot October 17, 2025 19:24

Copilot AI reviewed Oct 17, 2025

View reviewed changes

...Glacier2/session/server/src/main/java/com/example/glacier2/session/server/SharedPokeBox.java Outdated Show resolved Hide resolved

...Glacier2/session/server/src/main/java/com/example/glacier2/session/server/SharedPokeBox.java Outdated Show resolved Hide resolved

InsertCreativityHere and others added 5 commits October 17, 2025 16:18

Update java/Glacier2/session/server/src/main/java/com/example/glacier…

ab4bf41

…2/session/server/SharedPokeBox.java Co-authored-by: Copilot <[email protected]>

Update java/Glacier2/session/server/src/main/java/com/example/glacier…

8500347

…2/session/server/SharedPokeBox.java Co-authored-by: Copilot <[email protected]>

Use new nightly repositories.

1afd644

Not worth the nitpick honestly...

eac41e4

Extra 's' which shouldn't be there.

0782ed5

InsertCreativityHere requested review from bernardnormier, Copilot, externl and pepone October 20, 2025 15:35

InsertCreativityHere marked this pull request as ready for review October 20, 2025 15:35

Copilot AI reviewed Oct 20, 2025

View reviewed changes

java/Glacier2/session/slice/PokeBox.ice Outdated Show resolved Hide resolved

Glacier2 in the Slice file comment.

51e0b55

externl approved these changes Oct 20, 2025

View reviewed changes

Added missing '@OverRide's.

e9c238c

bernardnormier approved these changes Oct 20, 2025

View reviewed changes

pepone approved these changes Oct 21, 2025

View reviewed changes

InsertCreativityHere added 2 commits October 22, 2025 10:24

Review fixes.

33c5a77

Put the comment back to the past.

eef400c

InsertCreativityHere requested a review from Copilot October 22, 2025 14:26

Copilot AI reviewed Oct 22, 2025

View reviewed changes

InsertCreativityHere merged commit 8584f68 into zeroc-ice:main Oct 22, 2025
11 of 16 checks passed

Uh oh!

Add Glacier2/session Demo to Java #647

Add Glacier2/session Demo to Java #647

Uh oh!

Conversation

InsertCreativityHere commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernardnormier Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

InsertCreativityHere commented Oct 17, 2025 •

edited

Loading

bernardnormier Oct 20, 2025 •

edited

Loading