Python Glacier2/session typing fixes #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR corrects Python type annotations in the Glacier2 session demo to align with the actual interface definitions and proper async function return types.
- Removed incorrect
| Noneunion fromgetPokeBoxreturn type - Fixed async function return type from
Awaitable[None]toNone - Renamed parameter from
sessionControltocontrolfor consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/Glacier2/session/server/poke_session/session.py | Fixed return type annotations for getPokeBox and destroy methods |
| python/Glacier2/session/server/poke_session/manager.py | Renamed sessionControl parameter to control throughout the create method |
externl
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the errors reported by pyright on Python Glacier2/session demo.