Skip to content

Conversation

@bernardnormier
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the use of Ice::createProperties() factory function with direct make_shared<Ice::Properties>() construction across multiple C++ demo applications in the Ice framework repository.

Key Changes:

  • Replaces Ice::createProperties(argc, argv) calls with make_shared<Ice::Properties>(argc, argv)
  • Updates both parameterized and parameterless createProperties() calls to use make_shared constructor
  • Affects client, server, and utility code across IceGrid, IceDiscovery, Ice, and DataStorm demos

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
cpp/IceGrid/locatorDiscovery/Client.cpp Updated properties initialization in locator discovery client
cpp/IceDiscovery/replication/Server.cpp Updated properties initialization in replication server
cpp/IceDiscovery/replication/Client.cpp Updated properties initialization in replication client
cpp/IceDiscovery/greeter/Server.cpp Updated properties initialization in greeter server
cpp/IceDiscovery/greeter/Client.cpp Updated properties initialization in greeter client
cpp/Ice/secure/ClientRun.cpp Updated properties initialization in secure client
cpp/Ice/context/Client.cpp Updated properties initialization in context demo client
cpp/Ice/config/Server.cpp Updated both parameterless and parameterized properties initialization in config server
cpp/Ice/config/Client.cpp Updated both parameterless and parameterized properties initialization in config client
cpp/Ice/cancellation/Server.cpp Updated properties initialization in cancellation server
cpp/DataStorm/node/Writer.cpp Updated properties initialization in DataStorm writer node
cpp/DataStorm/node/Reader.cpp Updated properties initialization in DataStorm reader node

@bernardnormier bernardnormier merged commit fc49f21 into zeroc-ice:main Oct 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants