-
Couldn't load subscription status.
- Fork 216
Delete Redundant Checkstyle Action from GitHub CI #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Redundant Checkstyle Action from GitHub CI #653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the CI workflow to disable checkstyle validation during Java demo builds by adding the -x checkStyleMain flag to the Gradle build command.
Key Change:
- Java demos now skip checkstyle validation during CI builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we prefer this setup. To me seems more logical to keep the default and don't run checkStyle as a separate workflow.
I think it makes sense for Ice, where it's clearer to see the builds passed and only checkstyle failed, For the demos, I'd be fine just getting rid of the checkstyle action and letting main CI handle it. |
360856c to
ffbdc12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
|
Reworked this PR to instead remove the checkstyle action. |
We're currently running Checkstyle over the repo twice, once in the main
java build, and another in a stand-alonecheckstyleaction. This PR deletes the standalone checkstyle action. There's no need to run it twice.Outdated:
We made this change in the main Ice repository, but I forgot to do the same for the demos.
See zeroc-ice/ice#4359
We have a separate action for running
checkstyle, so we don't want the main Java build running it as well.