C++ Glacier2/session demo #655

pepone · 2025-10-29T16:47:53Z

No description provided.

Copilot

Pull Request Overview

This PR adds a new Glacier2 Session demo to the C++ demos repository. The demo illustrates how to implement and configure a Session Manager with Glacier2, demonstrating session-based access control and per-user state management using a Pokémon-themed application.

Implements a complete session management system with Glacier2 router integration
Demonstrates the use of a shared servant pattern for implementing multiple objects
Includes client-server communication through a Glacier2 router with session-based authentication

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
cpp/Glacier2/session/config.glacier2	Glacier2 router configuration file with client/server endpoints and session manager settings
cpp/Glacier2/session/SharedPokeBox.h	Header for shared servant implementing the PokeBox interface
cpp/Glacier2/session/SharedPokeBox.cpp	Implementation of shared PokeBox servant with session-based user ID resolution
cpp/Glacier2/session/SessionManager.h	Header for SessionManager servant that creates sessions and resolves user IDs
cpp/Glacier2/session/SessionManager.cpp	Implementation of SessionManager with session token management
cpp/Glacier2/session/Server.cpp	Server application that hosts the SessionManager and SharedPokeBox
cpp/Glacier2/session/README.md	Documentation for building and running the demo
cpp/Glacier2/session/PokeBox.ice	Slice definitions for PokeBox and PokeSession interfaces
cpp/Glacier2/session/InMemoryPokeStore.h	Header for in-memory Pokémon storage implementation
cpp/Glacier2/session/InMemoryPokeStore.cpp	Implementation of in-memory Pokémon storage
cpp/Glacier2/session/IUserIdResolver.h	Interface for resolving user IDs from session tokens
cpp/Glacier2/session/IPokeStore.h	Interface for Pokémon storage operations
cpp/Glacier2/session/DefaultPokeSession.h	Header for PokeSession servant implementation
cpp/Glacier2/session/DefaultPokeSession.cpp	Implementation of PokeSession with session lifecycle management
cpp/Glacier2/session/Client.cpp	Client application demonstrating session creation and usage
cpp/Glacier2/session/CMakeLists.txt	CMake build configuration for the demo
cpp/Glacier2/session/.gitignore	Git ignore file for build artifacts

cpp/Glacier2/session/README.md

externl

Looks good!

cpp/Glacier2/session/Client.cpp

Co-authored-by: Copilot <[email protected]>

InsertCreativityHere · 2025-10-29T18:54:15Z

cpp/Glacier2/session/IPokeStore.h

+namespace Server
+{
+    /// Represents a Pokémon storage system.
+    class IPokeStore


I don't think we use the I prefix for interfaces convention in C++, do we?
This should probably just be PokeStore like we do in the non-C# languages.

InsertCreativityHere · 2025-10-29T18:59:48Z

cpp/Glacier2/session/IPokeStore.h

+#define IPOKE_STORE_H
+
+#include "PokeBox.h"
+#include <list>


Do we need to #include list here? We never use list, just PokemonList from Pokebox.h.
Which I think gets mapped to an std::vector anyways by default.

Suggested change

#include <list>

InsertCreativityHere · 2025-10-29T19:00:56Z

cpp/Glacier2/session/IUserIdResolver.h

+namespace Server
+{
+    /// Resolves a user ID from a session token.
+    class IUserIdResolver


Same, I feel like in C++ we'd just use UserIdResolver.

InsertCreativityHere · 2025-10-29T19:02:03Z

cpp/Glacier2/session/IUserIdResolver.h

+    public:
+        /// Gets the user ID associated with the specified session token.
+        /// @param token The session token.
+        /// @returns The user ID associated with the specified session token, or null if not found.


Since this returns an optional and not a pointer.

Suggested change

/// @returns The user ID associated with the specified session token, or null if not found.

/// @returns The user ID associated with the specified session token, or nullopt if not found.

InsertCreativityHere · 2025-10-29T19:03:27Z

cpp/Glacier2/session/IPokeStore.h

+
+    using IPokeStorePtr = std::shared_ptr<IPokeStore>;
+}
+#endif


Usually an extra line separating the endif from the actual code.

Suggested change

#endif

#endif

InsertCreativityHere · 2025-10-29T19:17:13Z

cpp/Glacier2/session/SharedPokeBox.h

+        /// @param current Information about the incoming request being dispatched.
+        std::string getUserId(const Ice::Current& current) const;


Doesn't have an @returns. To be fair, this looks like it was also forgotten in the C# demo too.

Suggested change

/// @param current Information about the incoming request being dispatched.

std::string getUserId(const Ice::Current& current) const;

/// @param current Information about the incoming request being dispatched.

/// @returns The user ID associated with the current session.

std::string getUserId(const Ice::Current& current) const;

InsertCreativityHere · 2025-10-29T19:38:05Z

cpp/Glacier2/session/SessionManager.h

+            std::optional<Glacier2::SessionControlPrx> sessionControl,
+            const Ice::Current& current) final;
+
+        std::optional<std::string> getUserId(const std::string& token) final;


Can this be const like the other getters?

Suggested change

std::optional<std::string> getUserId(const std::string& token) final;

std::optional<std::string> getUserId(const std::string& token) const final;

InsertCreativityHere · 2025-10-29T19:47:18Z

cpp/Glacier2/session/DefaultPokeSession.cpp

+void
+DefaultPokeSession::destroy(const Ice::Current& current)
+{
+    std::cout << "Destroying session #" << current.id.name << std::endl;


We're using std in this file. Also we didn't qualify cout or endl in SharedPokebox.cpp either.
So for consistency:

Suggested change

std::cout << "Destroying session #" << current.id.name << std::endl;

cout << "Destroying session #" << current.id.name << endl;

InsertCreativityHere · 2025-10-29T19:51:20Z

cpp/Glacier2/session/README.md

+   > You can also start the Glacier2 router before the server. The order does not matter: the server is identical to the
+   > server provided in the [Ice Greeter][1] demo and does not depend on Glacier2.


This is the comment we use for the other Glacier2 session demos:

Suggested change

> You can also start the Glacier2 router before the server. The order does not matter: the server is identical to the

> server provided in the [Ice Greeter][1] demo and does not depend on Glacier2.

> You can also start the Glacier2 router before the server. The order does not matter.

The rest is leftover from the Glacier2 greeter demo.
I did the same thing when writing the Java session demo : vP

InsertCreativityHere · 2025-10-29T19:52:09Z

cpp/Glacier2/session/README.md

+
+    If you don't specify a name, the client uses the current username.
+
+[1]: ../../Ice/Greeter


And then this isn't necessary anymore, since we don't reference the Greeter demo.

Suggested change

[1]: ../../Ice/Greeter

pepone added 3 commits October 28, 2025 18:42

C++ Glacier2/session demo

80923dd

Checkpoint

e6eccd8

Review fixes

c028810

pepone requested review from InsertCreativityHere, Copilot and externl October 29, 2025 16:47

Copilot AI reviewed Oct 29, 2025

View reviewed changes

cpp/Glacier2/session/README.md Outdated Show resolved Hide resolved

externl approved these changes Oct 29, 2025

View reviewed changes

cpp/Glacier2/session/Client.cpp Outdated Show resolved Hide resolved

cpp/Glacier2/session/Client.cpp Outdated Show resolved Hide resolved

pepone and others added 5 commits October 29, 2025 18:36

Review fixes

90a191f

Review fixes

e610d48

Fix Windows build failures

bc4698e

Apply suggestion from @Copilot

197b213

Co-authored-by: Copilot <[email protected]>

clang-tidy fixes

7346cea

InsertCreativityHere approved these changes Oct 29, 2025

View reviewed changes

	/// @returns The user ID associated with the specified session token, or null if not found.
	/// @returns The user ID associated with the specified session token, or nullopt if not found.

		/// @param current Information about the incoming request being dispatched.
		std::string getUserId(const Ice::Current& current) const;

	std::optional<std::string> getUserId(const std::string& token) final;
	std::optional<std::string> getUserId(const std::string& token) const final;

	std::cout << "Destroying session #" << current.id.name << std::endl;
	cout << "Destroying session #" << current.id.name << endl;

		> You can also start the Glacier2 router before the server. The order does not matter: the server is identical to the
		> server provided in the [Ice Greeter][1] demo and does not depend on Glacier2.


		If you don't specify a name, the client uses the current username.

		[1]: ../../Ice/Greeter

Uh oh!

C++ Glacier2/session demo #655

Are you sure you want to change the base?

C++ Glacier2/session demo #655

Conversation

pepone commented Oct 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

externl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants