Return signed URL directly in TikTokSignatureProvider instead of calling sign URL endpoint #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calling sign URL endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
webcast/sign_urlendpoint is deprecated, so this PR rewrites the function to return the signed URL directly instead of calling the endpoint. This should theoretically improve the speed since the library will only need to make one request instead of two.This PR also removes
configandsignEventsas they are not used elsewhere.Breaking changes: this might cause issues for people who are using a custom host and the
webcast/sign_urlendpoint to sign URL. Additionally, this change eliminates the need forsignProviderOptions.paramsandsignProviderOptions.headers.