feat(richlogger): Enhance Rich Logger Performance with Field Processing Caching#5187
Open
DengY11 wants to merge 11 commits intozeromicro:masterfrom
Open
feat(richlogger): Enhance Rich Logger Performance with Field Processing Caching#5187DengY11 wants to merge 11 commits intozeromicro:masterfrom
DengY11 wants to merge 11 commits intozeromicro:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
i have tried many other ways, such as adding a member to the struct richlogger to avoid using the map cache, but it requires a much bigger change ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a performance optimization for the rich logger by implementing a caching mechanism that avoids repeated processFieldValue calls for the same field names. The solution adds a unique logger ID system and caches field processors to eliminate reflection overhead.
Changes Made
Logger ID System
Added atomic counter loggerIDCounter to generate unique IDs for each logger instance
Modified rich logger methods (WithCallerSkip, WithContext, WithDuration, WithFields) to generate new unique IDs using atomic.AddUint64(&loggerIDCounter, 1)
Caching Mechanism
Cache Key: loggerID (e.g., "123")
Cache Value: a slice of field processor functions that handle specific field types without reflection
Performance Optimization
Before: Every field value processed through processFieldValue with reflection overhead
After: Field processors cached per field name, processing happens only once per field type
Benefits: Eliminates reflection overhead for repeated field names, significant performance improvement for loggers with many fields
Writer Interface Changes
This is a break change
close #5067
I also create benchmark with 10 fields and 1000 fields
The benchmark shows higher performance and less memory use and allocs