fix(conf): support equal signs in property values#5392
Merged
kevwan merged 1 commit intozeromicro:masterfrom Feb 1, 2026
Merged
fix(conf): support equal signs in property values#5392kevwan merged 1 commit intozeromicro:masterfrom
kevwan merged 1 commit intozeromicro:masterfrom
Conversation
kevwan
approved these changes
Jan 30, 2026
Use strings.SplitN instead of strings.Split to only split on the first equal sign, allowing values to contain equal signs. This fixes parsing failures for database URLs, base64 strings, and other values containing equal signs.
kevwan
force-pushed
the
fix/properties-split
branch
from
204e7c5 to
20abf68
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use strings.SplitN instead of strings.Split to only split on the first equal sign, allowing values to contain equal signs. This fixes parsing failures for database URLs, base64 strings, and other values containing equal signs.