Fix std::max compilation error on Windows #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

gummif merged 1 commit into zeromq:master from cacharle:fix-std-max-compilation-error

Apr 18, 2025

Contributor

cacharle commented Apr 17, 2025

Fixes #654


          Fix std::max compilation error on Windows

a6035ca

Fixes zeromq#654

Contributor Author

cacharle commented Apr 18, 2025

I might be blind but I do not see the Windows CI/CD compile errors

Member

gummif commented Apr 18, 2025

Yeah, it has not worked for a while. I think this is fine since it works on gcc and clang.

gummif merged commit 78f91ad into zeromq:master

2 of 10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet