[PROBLEM] No custom memory allocator for msg can be provided #4125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by completely removing malloc/free from the hot path of benchmark util
…pool # Conflicts: # src/msg.cpp # src/msg.hpp # src/zmq.cpp
In practice I observed that 256 byte messages require +- 1024 messages pre-allocated to reach max. performance on my pc. This scales depending on message size I believe.
added 30 commits
May 12, 2020 22:04
Consider switch to range based for (only since C++11 though)
Changed some options that should not have changed
Cpp equivalent of malloc/free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preamble to #3911 but I think that one got a bit big. I would like to discuss the API first.