Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: don't use builtin sha1 if not using ws #4670

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

fanquake
Copy link
Contributor

The builtin SHA1 (ZMQ_USE_BUILTIN_SHA1) is only used in the websocket engine (ws_engine.cpp), so if websockets are disabled, i.e -DENABLE_DRAFTS=OFF, don't add sha1.c to the sources list.

The builtin SHA1 (ZMQ_USE_BUILTIN_SHA1) is only used in the websocket
engine (ws_engine.cpp), so if websockets are disabled, i.e
-DENABLE_DRAFTS=OFF, don't add sha1.c to the sources list.
@bluca bluca merged commit 2a75ef0 into zeromq:master Mar 25, 2024
59 of 61 checks passed
@fanquake fanquake deleted the skip_sha1_no_websockets branch March 25, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants