WSS: use hostname from URL if not specified - #4914
Open
YunYe-Pu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when using WSS client, TLS hostname must be set with
ZMQ_WSS_HOSTNAMEoption, otherwise no SNI is sent to server, and the server may reject the handshake. This means if we want to connect one ZMQ socket to multiple WSS servers, we need to write something like this:Which is a bit cumbersome compared to other transports.
Since in production, TLS without SNI is rarely used, it might be beneficial to have WSS client send the SNI by default.
Proposal
When
ZMQ_WSS_HOSTNAMEis empty, and when the WSS URL contains a valid domain name, use domain name in URL as the TLS hostname.ZMQ_WSS_HOSTNAMEstill works in case we need to override the hostname. Other wss-related options are unaffected.