Fix buffer leak on contended CONFLATE socket - #4925
Open
rschlaikjer wants to merge 2 commits into
Open
Conversation
Calling write on dbuffer first places the input msg_t in _back, then attempts to swap it with _front. However, if the swap fails, _back doesn't get reset. If another write then comes in, it overwrites the value in _back without releasing it first. This can cause memory leaks when CONFLATE is enabled on a contended socket.
rschlaikjer
force-pushed
the
rs-dbuffer-leak
branch
from
July 28, 2026 02:10
3d94583 to
86e0770
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling write on dbuffer first places the input
msg_tin_back, then attempts to swap it with_front.However, if the swap fails,
_backdoesn't get reset. If another write then comes in, it overwrites the value in _back without releasing it first.This can cause memory leaks when
CONFLATEis enabled on a contended socket.Fix this by always closing
_backas part ofwrite.