Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poller.remove socket disposed fix #835

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
3b8dbb9
added NetMQPollerTest.RemoveAndDisposeSocket() as a repro for issue #834
jasells Dec 3, 2019
d0f2725
Task refactor of .Remove(ISocketPollable) passes test!
jasells Dec 4, 2019
53e1833
speed up the test a little
jasells Dec 4, 2019
68429d7
async fix supporting .NET40, broke a test
jasells Dec 4, 2019
dea90f4
un-break the API back to sycnronous (but now working)
jasells Dec 8, 2019
6b344ca
rename new test to avoid confusion
jasells Dec 8, 2019
c879804
fixed RemoveAndDispose()
jasells Dec 8, 2019
54c2931
fix other Remove methods
jasells Dec 8, 2019
bc362a9
clean up the RUn method for .NET40 compat
jasells Dec 8, 2019
98a0f00
undo changes in RemoveThrowsIfSocketAlreadyDisposed
jasells Dec 8, 2019
a3819e1
fixing spacing complaints
jasells Dec 8, 2019
4f3b1e6
return task from tests
jasells Dec 21, 2019
33816cb
fixing wait() calls
jasells Dec 21, 2019
bda8b3f
use Task.Factory.StartNew
jasells Dec 21, 2019
cb16939
initial refactor works, except for one test.
jasells Feb 18, 2020
544bb94
fix Selector to handle disposed sockets
jasells Feb 18, 2020
87b7649
added comment about previous commmit
jasells Feb 18, 2020
92163b1
removed comment
jasells Feb 18, 2020
51457d1
fix region tag formatting
jasells Feb 18, 2020
fce2bb0
sync with master
jasells Feb 29, 2020
38910d8
updated comments
jasells Feb 29, 2020
3bacfb8
cleaer names for async socket remove tests
jasells Feb 29, 2020
455f6b0
I believe this should address the net45/net40 Task.FromResult() concern
jasells Feb 29, 2020
52fa20e
ensure tasks are queued on the poller, not the task pool.
jasells Mar 31, 2020
884d4ea
remove the dictionary checks.
jasells Mar 31, 2020
9f17258
fix indentation
jasells Mar 31, 2020
3ea0693
removed comment that needs seperate PR
jasells Apr 7, 2020
72ebdbc
added RemoveAsync(Socket ) overload
jasells Apr 24, 2020
c14f9f9
comment update
jasells Apr 24, 2020
0a767c6
added REmoveASync(timer) overload and test
jasells Apr 24, 2020
fa5e49b
fix depricated message
jasells Apr 24, 2020
83a34b6
refactored ContainsAsync() methods
jasells Apr 24, 2020
217e4f4
added doc block
jasells Apr 24, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
comment update
jasells committed Apr 24, 2020
commit c14f9f942d63ba0fca7a8492996a488c636ef836
2 changes: 1 addition & 1 deletion src/NetMQ/NetMQPoller.cs
Original file line number Diff line number Diff line change
@@ -392,7 +392,7 @@ public void Remove([NotNull] NetMQTimer timer)
/// </summary>
/// <param name="socket">The socket to remove</param>
/// <exception cref="ArgumentNullException">If socket is null</exception>
[Obsolete("Queues the action on the poller's thread, but provides no sync mechanism. Please use RemoveAsync() instead")]
[Obsolete("Queues an action on the poller's thread, but provides no sync mechanism. Please use RemoveAsync() instead")]
public void Remove([NotNull] Socket socket)
{
RemoveAsync(socket);