-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change to use secrets.github_token #168
change to use secrets.github_token #168
Conversation
try again github_token
This reverts commit 2e69e4f.
Still seems to fail: https://github.com/zeromq/pyre/actions/runs/12647343395/job/35239553757 |
thanks, taking a look |
@sphaero please could you take a look at this section to ensure that the permissions for this token are set correctly: |
when will you be able to take a look at this @sphaero? thanks |
Seems OK. The settings are the same as in the screenshot. |
ok, i've found the problem although i'm still working on understanding the cause. The job is set up with a GITHUB_TOKEN that only has read permissions, it is curious because i see the correct permissions being used for the test workflow. https://github.com/zeromq/pyre/actions/workflows/test.yml please can you try to manually run the workflow on the master branch? |
It's custom in the zeromq organisation to invite submitters to the maintainers pool. If you want this I can add you so you can have a look yourself. |
yes please |
change to use secrets.github_token
follows the docs: https://github.com/ad-m/github-push-action
tested: https://github.com/philrhc/pyre/actions/runs/12647148905