Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to use secrets.github_token #168

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

philrhc
Copy link

@philrhc philrhc commented Jan 7, 2025

Phil Cummins and others added 3 commits January 7, 2025 08:30
@sphaero sphaero merged commit a9ed346 into zeromq:master Jan 7, 2025
7 checks passed
@sphaero
Copy link
Contributor

sphaero commented Jan 7, 2025

@philrhc
Copy link
Author

philrhc commented Jan 7, 2025

Still seems to fail: https://github.com/zeromq/pyre/actions/runs/12647343395/job/35239553757

thanks, taking a look

@philrhc
Copy link
Author

philrhc commented Jan 7, 2025

remote: Permission to zeromq/pyre.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/zeromq/pyre.git/': The requested URL returned error: 403

@sphaero please could you take a look at this section to ensure that the permissions for this token are set correctly:
https://github.com/ad-m/github-push-action?tab=readme-ov-file#requirements-and-prerequisites

@philrhc
Copy link
Author

philrhc commented Jan 8, 2025

when will you be able to take a look at this @sphaero? thanks
#168 (comment)

@sphaero
Copy link
Contributor

sphaero commented Jan 9, 2025

Seems OK. The settings are the same as in the screenshot.

@sphaero
Copy link
Contributor

sphaero commented Jan 9, 2025

@philrhc philrhc deleted the github-push-action-github-token branch January 13, 2025 08:25
@philrhc
Copy link
Author

philrhc commented Jan 13, 2025

ok, i've found the problem although i'm still working on understanding the cause. The job is set up with a GITHUB_TOKEN that only has read permissions, it is curious because i see the correct permissions being used for the test workflow. https://github.com/zeromq/pyre/actions/workflows/test.yml

please can you try to manually run the workflow on the master branch?
https://github.com/zeromq/pyre/actions/workflows/bump_version.yml

@sphaero
Copy link
Contributor

sphaero commented Jan 13, 2025

It's custom in the zeromq organisation to invite submitters to the maintainers pool. If you want this I can add you so you can have a look yourself.

@philrhc
Copy link
Author

philrhc commented Jan 13, 2025

yes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants