-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade python version used in setup-python #170
Conversation
.github/workflows/test.yml
Outdated
- name: Display structure of downloaded files | ||
run: ls -R dist/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run ls -R dist/
dist/:
zeromq_pyre-0.3.4.tar.gz
hi @sphaero, thank you for adding me. |
Read this: https://rfc.zeromq.org/spec/42/ That's how we work. You never merge your own PR's |
this is a really awesome document and i am honoured to be a part of it. Thank you for the opportunity |
You're welcome. |
Any more changes pending? I was looking at the dist/zeromq_pyre dist/zeromq-pyre difference. Why are you proposing that change? From the logs I get it has always been dist/zeromq-pyre |
i am not sure why it has changed, but the log line and passing tests prove that it has: |
there are no more pending changes for this pr. |
But who creates those files? I'm not too familiar with these tools |
https://github.com/zeromq/pyre/blob/master/.github/workflows/test.yml#L9 |
Seems it's a known thing: https://mail.python.org/pipermail/distutils-sig/2011-August/017936.html
|
yes, the version can be bumped manually as suspected: |
Sure why wouldn't you/why would you. |
Strange to suddenly started failing here: https://github.com/zeromq/pyre/actions/runs/12744306550
in any case, the versions are old and may as well be updated