Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade python version used in setup-python #170

Merged
merged 6 commits into from
Jan 13, 2025

Conversation

philrhc
Copy link

@philrhc philrhc commented Jan 13, 2025

Strange to suddenly started failing here: https://github.com/zeromq/pyre/actions/runs/12744306550
in any case, the versions are old and may as well be updated

Comment on lines 48 to 49
- name: Display structure of downloaded files
run: ls -R dist/
Copy link
Author

@philrhc philrhc Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: delete

Copy link
Author

@philrhc philrhc Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run ls -R dist/
dist/:
zeromq_pyre-0.3.4.tar.gz

@philrhc philrhc changed the title upgrade python version used in setup-python WIP: upgrade python version used in setup-python Jan 13, 2025
@philrhc
Copy link
Author

philrhc commented Jan 13, 2025

hi @sphaero, thank you for adding me.
i propose to still share PRs here for you to get approval before merging to master,
what do you think?

@philrhc philrhc changed the title WIP: upgrade python version used in setup-python upgrade python version used in setup-python Jan 13, 2025
@sphaero
Copy link
Contributor

sphaero commented Jan 13, 2025

Read this: https://rfc.zeromq.org/spec/42/

That's how we work. You never merge your own PR's

@philrhc
Copy link
Author

philrhc commented Jan 13, 2025

Read this: https://rfc.zeromq.org/spec/42/

That's how we work. You never merge your own PR's

this is a really awesome document and i am honoured to be a part of it. Thank you for the opportunity

@philrhc philrhc requested a review from sphaero January 13, 2025 10:13
@sphaero
Copy link
Contributor

sphaero commented Jan 13, 2025

You're welcome.

@sphaero
Copy link
Contributor

sphaero commented Jan 13, 2025

Any more changes pending? I was looking at the dist/zeromq_pyre dist/zeromq-pyre difference. Why are you proposing that change? From the logs I get it has always been dist/zeromq-pyre

@philrhc
Copy link
Author

philrhc commented Jan 13, 2025

Any more changes pending? I was looking at the dist/zeromq_pyre dist/zeromq-pyre difference. Why are you proposing that change? From the logs I get it has always been dist/zeromq-pyre

i am not sure why it has changed, but the log line and passing tests prove that it has:
#170 (comment)

@philrhc
Copy link
Author

philrhc commented Jan 13, 2025

there are no more pending changes for this pr.
i think that after this, the manual version bump will work correctly, i think that this will show me that the failing automated version bump happens because it is ran in the context of the pr
https://github.com/zeromq/pyre/actions/workflows/bump_version.yml
i will then submit another pr to resolve that issue

@sphaero
Copy link
Contributor

sphaero commented Jan 13, 2025

Any more changes pending? I was looking at the dist/zeromq_pyre dist/zeromq-pyre difference. Why are you proposing that change? From the logs I get it has always been dist/zeromq-pyre

i am not sure why it has changed, but the log line and passing tests prove that it has: #170 (comment)

But who creates those files? I'm not too familiar with these tools

@philrhc
Copy link
Author

philrhc commented Jan 13, 2025

Any more changes pending? I was looking at the dist/zeromq_pyre dist/zeromq-pyre difference. Why are you proposing that change? From the logs I get it has always been dist/zeromq-pyre

i am not sure why it has changed, but the log line and passing tests prove that it has: #170 (comment)

But who creates those files? I'm not too familiar with these tools

https://github.com/zeromq/pyre/blob/master/.github/workflows/test.yml#L9

@sphaero
Copy link
Contributor

sphaero commented Jan 13, 2025

Seems it's a known thing: https://mail.python.org/pipermail/distutils-sig/2011-August/017936.html

Distutils 
normally uses '-' to separate name parts in a filename, and 
(sometimes) escapes '-' using '_'.  So setuptools canonicalizes all 
punctuation to '-', and escapes it as '_'.

@sphaero sphaero merged commit 48b659d into zeromq:master Jan 13, 2025
7 checks passed
@philrhc
Copy link
Author

philrhc commented Jan 13, 2025

yes, the version can be bumped manually as suspected:
https://github.com/zeromq/pyre/actions/runs/12745682701

@philrhc philrhc deleted the upgrade-python-version branch January 13, 2025 10:55
@philrhc
Copy link
Author

philrhc commented Jan 13, 2025

@sphaero please can we/I deploy 0.3.5 to PyPi?
8fb98d5

@sphaero
Copy link
Contributor

sphaero commented Jan 13, 2025

Sure why wouldn't you/why would you.
I don't know. I don't use Pyre anymore and I've never used it through PyPi. If you need this pushed to PyPi then go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants