Ensure members in PacketMultiplexer are initialized#2535
Merged
joseph-henry merged 1 commit intozerotier:devfrom Nov 3, 2025
Merged
Ensure members in PacketMultiplexer are initialized#2535joseph-henry merged 1 commit intozerotier:devfrom
joseph-henry merged 1 commit intozerotier:devfrom
Conversation
_enabled is set to true by setUpPostDecodeReceiveThreads(), so disabled until then, but the constructor wasn't initializing it. _concurrency is not being used before being set but for safety's sake, ensure it has a starting value as well. Also, remove the vestigial _rxThreadCount, which is no longer used.
|
|
joseph-henry
approved these changes
Nov 3, 2025
Contributor
joseph-henry
left a comment
joseph-henry
left a comment
There was a problem hiding this comment.
Thanks for taking care of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_enabled is set to true by setUpPostDecodeReceiveThreads(), so disabled until then, but the constructor wasn't initializing it. _concurrency is not being used before being set but for safety's sake, ensure it has a starting value as well.
Also, remove the vestigial _rxThreadCount, which is no longer used.