Skip to content

Conversation

@cswinter
Copy link

Fixes #15

@zesterer
Copy link
Owner

Thanks!

@zesterer
Copy link
Owner

Looks like there's a bit more to do on this PR: adding a few Clone constraints in derives. It's likely going to be a breaking change.

@mxthevs
Copy link

mxthevs commented Jun 12, 2022

What is the status of this PR? I would love to have a clone method both on ReportBuilder and Report :)

@zesterer
Copy link
Owner

It looks like it just needs someone to pick it up again.

@TornaxO7
Copy link

TornaxO7 commented Jun 14, 2022

I looked a little bit, if I can pick this PR, but when I saw this, I was a little unsure what the best approach would be.

@zesterer
Copy link
Owner

The comment in that file only really relates to the logic for actually generating a diagnostic. Implementing Clone for ReportBuilder is just a case of writing a manual Clone impl with the correct bounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement clone on ReportBuilder

4 participants