Skip to content

Conversation

@nikabyn
Copy link
Contributor

@nikabyn nikabyn commented Mar 11, 2023

Implementation of #303
Adds a debug panic for left recursive parsers without memoization.

@zesterer
Copy link
Owner

Unfortunately, I don't think the changes in this PR are sufficient by themselves. For example, I'm pretty sure any mutually recursive pattern will not be caught, such as this:

recursive(|a| {
    recursive(move |_| {
        a
    })
})

I think unfortunately something more substantial is required, like piggy-backing on top of the memoisation hashmap.

@zesterer
Copy link
Owner

Now being worked on in #371

@zesterer zesterer closed this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants