Added with_slice, updated logos example #439
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to have also a lasso integration. |
Comment on lines
34
to
38
| #[regex(r"[ \t\f\n]+", logos::skip)] | ||
| Whitespace, |
There was a problem hiding this comment.
Can be moved under the #[derive(...)] using #[logos(skip r"[ \t\f\n]+")]
| ) -> impl Parser<'a, I, SExpr, extra::Err<Rich<'a, Token<'a>>>> { | ||
| fn parser<'a, I>() -> impl Parser<'a, I, SExpr, extra::Err<Rich<'a, Token<'a>>>> | ||
| where | ||
| I: ValueInput<'a, Token = Token<'a>, Span = SimpleSpan> + SliceInput<'a, Slice = &'a str>, |
There was a problem hiding this comment.
Tbf, to avaid humongous types, trait "aliases" should be used.
pub type TokenParserExtra<'a> = Full<Rich<'a, Token>, (), ()>;
pub trait TokenInput<'a>: ValueInput<'a, Token = Token, Span = SimpleSpan> {}
impl<'a, T> TokenInput<'a> for T where T: ValueInput<'a, Token = Token, Span = SimpleSpan> {}
pub trait TokenParser<'a, I: TokenInput<'a>, O>:
Parser<'a, I, O, TokenParserExtra<'a>> + Clone {
}
impl<'a, I: TokenInput<'a>, O, T> TokenParser<'a, I, O> for T where T: Parser<'a, I, O, TokenParserExtra<'a>> + Clone {}until real trait aliases are available
Contributor
Would this not be equivalent to: ident().map_with_state(|i, _, rodeo: &Rodeo| rodeo.get_or_intern(i)) |
Yes, I will use trait extensions for that then. |
zesterer
force-pushed
the
main
branch
5 times, most recently
from
38bb88c to
02a1373
Compare
zesterer
force-pushed
the
main
branch
2 times, most recently
from
0f2b61a to
e350fc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently unsound if passed an incorrectly sized slice.