Add recursive_fold and recursive_2 to prevent memory leaks #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
How do you think this solution compares to #494 ? |
Author
zesterer
force-pushed
the
main
branch
5 times, most recently
from
38bb88c to
02a1373
Compare
Zij-IT
added a commit
to Zij-IT/chumsky
that referenced
this pull request
Oct 27, 2025
This commit (hopefully) renders `define` and `declare` for users of the library obselete, by adding a parser which wraps the declaration and definition similar to `recursive`. This `recursive_n` allows for the definition of mutually recursive parsers, resulting in a single parser. This solves the memory leak in a fashion similar to zesterer#664 by keeping all strong references within `RecursiveN` and dropping these all whenever the parser returned by `recursive_n` is dropped. Additionally, `Recursive::declare` and `Recursive::define` are removed from the API.
* Make nested_in more flexible * Semver break
jkylling
force-pushed
the
add-recursive-fold-main
branch
from
db038db to
f7c378e
Compare
zesterer
force-pushed
the
main
branch
2 times, most recently
from
0f2b61a to
e350fc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
recursive_2orrecursive_foldinstead ofRecursive::declarewe can prevent situations where we either keep too many strong references around, leading to memory leaks, or too few strong references around, leading to broken parsers because all the strong references and the parsers are dropped.We could consider removing
Recursive::declarefrom the public API, since it is hard to use it correctly.Please see the investigation (for version 0.9) in #486 (comment)
If code is migrated to use
recursive_2orrecursive_foldwe should be able to resolve #486 I have tested that this patch for 0.9 fixes the memory issue on jaq when repeatedly creating parsers.