Skip to content
This repository was archived by the owner on Apr 2, 2026. It is now read-only.

fix: try_map loses some of what is expected in error when used sequentially (#827)#828

Merged
Hedgehogo merged 10 commits into
zesterer:mainfrom
Hedgehogo:fix_try_map_error
Aug 14, 2025
Merged

fix: try_map loses some of what is expected in error when used sequentially (#827)#828
Hedgehogo merged 10 commits into
zesterer:mainfrom
Hedgehogo:fix_try_map_error

Conversation

@Hedgehogo

@Hedgehogo Hedgehogo commented Jul 1, 2025

Copy link
Copy Markdown
Collaborator

Fix for #827

@Hedgehogo Hedgehogo changed the title fix: try_map loses some of what is expected in error when used sequentially #827 fix: try_map loses some of what is expected in error when used sequentially (#827) Jul 1, 2025
@Hedgehogo
Hedgehogo marked this pull request as draft August 12, 2025 17:29

@zesterer zesterer left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, I'd missed that the old_alt ends up getting forgotten on failure. Thanks!

Let me know when you're ready to take this out of draught and merge.

@Hedgehogo

Copy link
Copy Markdown
Collaborator Author

Let me know when you're ready to take this out of draught and merge.

I noticed that I haven't fixed try_map_with.

@Hedgehogo
Hedgehogo marked this pull request as ready for review August 13, 2025 08:02
@Hedgehogo
Hedgehogo merged commit 317fabe into zesterer:main Aug 14, 2025
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants