This repository was archived by the owner on Apr 2, 2026. It is now read-only.
fix: separated_by crashes with an error when it shouldn't (#799)#830
Closed
Hedgehogo wants to merge 4 commits into
Closed
fix: separated_by crashes with an error when it shouldn't (#799)#830Hedgehogo wants to merge 4 commits into
separated_by crashes with an error when it shouldn't (#799)#830Hedgehogo wants to merge 4 commits into
Conversation
zesterer
reviewed
Aug 12, 2025
Comment on lines
+2025
to
+2033
| if !first_loop { | ||
| debug_assert!( | ||
| before != inp.cursor(), | ||
| "found SeparatedBy combinator making no progress at {}", | ||
| self.location, | ||
| ); | ||
| } else { | ||
| first_loop = false; | ||
| } |
Owner
There was a problem hiding this comment.
Hmm. Maybe this logic should be moved to the IterParser implementation so it works for .separated_by(...).collect() too? What do you think?
Collaborator
Author
There was a problem hiding this comment.
Hmm. Maybe this logic should be moved to the
IterParserimplementation so it works for.separated_by(...).collect()too? What do you think?
I've been thinking, I think we need the ability to call next by telling it whether to respond to a lack of progress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.