This repository was archived by the owner on Apr 2, 2026. It is now read-only.
fix: label all errors that occur in text parsers (#826)#834
Merged
Conversation
Label errors that occur when there is no token, and not just when they do not meet expectations.
zesterer
reviewed
Jul 1, 2025
Collaborator
Author
Owner
|
Looks like tests are still failing on this, FYI. |
Collaborator
Author
|
And I wrote why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Label errors that occur when there is no token, and not just when they do not meet expectations.
The
tests::labelstest crashes for the reason described in #832.