This repository was archived by the owner on Apr 2, 2026. It is now read-only.
fix: rewind generates incorrect errors (#843)#844
Closed
Hedgehogo wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Accepted together with #859. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a temporary fix that fixes the problem, but loses some of the error information (Which generally does not violate any chumsky principles, it does not guarantee the completeness of errors).
The best solution would be to keep two
Cursors insideLocation, one referring to the current location, as usual, and the second to the last location outside of rewind. This also requires entering a separate marker where this location was. However, this is a major change that requires further discussion.