Attempt to automagically generate jump tables for choice #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zesterer
force-pushed
the
auto_jump_tables
branch
from
4c8c28c to
b1ef864
Compare
zesterer
force-pushed
the
auto_jump_tables
branch
from
b1ef864 to
63b9dc8
Compare
zesterer
force-pushed
the
main
branch
2 times, most recently
from
0f2b61a to
e350fc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to automatically generate jump tables for
choicenodes in cases where all child parsers support presenting a predicate.Effectively, this is a 'free' optimisation that requires no changes to parser implementations.
Things would be improved even more if Rust supported first-class patterns, but alas.
There's more work to do, but the results are already positive (the 'vanilla' benchmarks are likely already optimised to jump tables and so do not experience the same speed-up).