This repository was archived by the owner on Apr 2, 2026. It is now read-only.
Update lockfile and assert up-to-date#904
Closed
tisonkun wants to merge 2 commits into
Closed
Conversation
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Nov 6, 2025
Comment on lines
-181
to
+191
| version = "0.11.2" | ||
| version = "0.12.0" |
Contributor
Author
There was a problem hiding this comment.
This is the outdated lock info even if not update.
Owner
|
Hmm, I think it would simply be better to use |
Contributor
Author
|
Reasonable. Let me add it to |
Signed-off-by: tison <wander4096@gmail.com>
Contributor
Author
|
Updated at ae62501 |
Contributor
Author
|
reminder @zesterer now the patch should be ready for another review :D |
Owner
|
Oh, to clarify: I meant all of the steps. But the lockfile is now out of date (due to upstream changes) so I might close this PR and make the change separately, unless you were interested in updating it? |
Contributor
Author
|
As long as it would be fixed, I'm leaving the task now. If I find further issues, I'd file a new PR :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.