This repository was archived by the owner on Apr 2, 2026. It is now read-only.
Export InputRef::emit#913
Merged
Merged
Conversation
zesterer
reviewed
Nov 18, 2025
| self.cursor += skip; | ||
| } | ||
|
|
||
| /// Emits a non-fatal error |
Owner
There was a problem hiding this comment.
Thanks!
Could you clarify that it emits it at the current input position? (i.e: that it's akin to inp.emit_at(inp.cursor(), error))
Also, full stops for consistency please!
Updated documentation for emit and emit_at methods to clarify their functionality.
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #912.