Better delimiter errors #916
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
zesterer
commented
Nov 19, 2025
zesterer
commented
…ed delimiter errors
zesterer
force-pushed
the
better-delimiter-errors
branch
from
a9eb1d5 to
d84d7e7
Compare
Owner
Author
|
I'd be interested in your thoughts on this @Hedgehogo |
Hedgehogo
reviewed
Dec 3, 2025
| /// The span `start` is the span of the starting delimiter. | ||
| /// | ||
| /// `scope` is the span from (and including) the starting delimiter, up to the location of the error. | ||
| fn in_delimited(&mut self, start: I::Span, scope: I::Span) { |
Collaborator
There was a problem hiding this comment.
Why are we introducing this method? It imposes an additional obligation on current errors. It provides backward compatibility (albeit not significantly).
At the same time, we could instead create a label (DelimitersExpected) whose position would be the entire parser and which would contain the position of the opening separator as a field.
Owner
Author
There was a problem hiding this comment.
I think that makes sense, I'll have a go at that if I get a moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.