This repository was archived by the owner on Apr 2, 2026. It is now read-only.
Keep secondary errors on the last choice even if it fails#949
Merged
Conversation
Owner
|
Very well caught! I'm extremely surprised that this hadn't been noticed before, although come to think of it, it might explain some subtle edge cases I recall observing a few months ago when messing around with recovery behaviour. Thanks so much for taking the time to find this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
choice()was unnecessarily rewinding (and thus truncating the secondary errors) even on the last choice. This caused secondary errors to be swallowed. If you run the test I added with the main branch, you can see that it only returns one error.The new behavior I implemented was already the behavior when passing a slice of parsers to
choice(). So, this change can be seen as improving the consistency ofchoice()for tuples vs slices.