This repository was archived by the owner on Apr 2, 2026. It is now read-only.
Make RichReason generic over custom error type#962
Merged
Conversation
Owner
|
Thanks! I can't see anything wrong with this PR, much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #959
Makes it easier to provide richer customer errors without having to re-implement parts of
Rich.A lot of uses should be compatible, but any code that pattern matches on
RichReasonmight need updates, andRich::customchanged from taking anToStringto anInto<String>by default which isn't always compatible.The second incompatibility case could be solved by only having
Rich::custombe implemented forRich<_, _, String>and have a different method for the generic version if desired.