Use new nightly-only APIs for even more speed #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SludgePhD
reviewed
Jan 26, 2026
| // Clone the `Thread`, unpark the clone | ||
| thread.clone().unpark(); | ||
| // Forget the previously owned instance, since wake_by_ref doesn't take ownership | ||
| core::mem::forget(thread); |
There was a problem hiding this comment.
The clone() above will increment the reference count, but this forget prevents it from being decremented, so this will leak the Thread internals.
The clone() above has to be removed for this function to be leak-free.
Owner
Author
There was a problem hiding this comment.
You are correct. If I ever get round to work on this again I'll correct this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings a simple benchmark down from 10.3 seconds to 9.5 seconds.