Skip to content

Cargo fmt#48

Open
matthiasbeyer wants to merge 2 commits into
zesterer:masterfrom
matthiasbeyer:cargo-fmt
Open

Cargo fmt#48
matthiasbeyer wants to merge 2 commits into
zesterer:masterfrom
matthiasbeyer:cargo-fmt

Conversation

@matthiasbeyer

Copy link
Copy Markdown
Contributor

Hi!

As briefly discussed on mastodon, here goes my first patchset.

This PR does only run cargo-fmt on the codebase, as a first step. A later PR will introduce cargo-fmt checking in github actions.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@netlify

netlify Bot commented Mar 10, 2023

Copy link
Copy Markdown

Deploy Preview for thriving-beignet-855860 ready!

Name Link
🔨 Latest commit 77d74f6
🔍 Latest deploy log https://app.netlify.com/sites/thriving-beignet-855860/deploys/640ae114d39a0d0008506ab7
😎 Deploy Preview https://deploy-preview-48--thriving-beignet-855860.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

This was referenced Mar 10, 2023
@zesterer

zesterer commented Mar 10, 2023

Copy link
Copy Markdown
Owner

Unfortunately I'm not sure I can accept this PR at the moment. rustfmt has done some pretty painful things to some of the code here, particularly in and around the type solver. Perhaps in time when things are refactored and made cleaner a format pass would be a bit less painful to deal with, but for now there's too much that becomes actively harder to understand because of it :\

As a random example of something that goes from being neat and easy to reason about to simply being opaque visual noise:

image

@matthiasbeyer

Copy link
Copy Markdown
Contributor Author

Perhaps in time when things are refactored and made cleaner a format pass would be a bit less painful to deal with, but for now there's too much that becomes actively harder to understand because of it :\

I see where you're coming from... but wouldn't the other way round also be a sensible way? Format the codebase, which easily shows the bits that are refactor-worthy (like the bit you from your screenshot) and then refactor them? 😆

@zesterer

Copy link
Copy Markdown
Owner

Refactoring the type checker would be... A mammoth task. I absolutely want to do it at some point, but not before I figure out a formalisation for things like effect type inference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants