Skip to content

Update color pallete and toggle button component #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

geodem127
Copy link
Contributor

  • Update the "success" and "info" options in the theme palette to ensure the correct "contrastText" is applied.
  • Modify the "MuiToggleButton" to set the font size of the small variant to "14px" for consistency with other components' small variants.
  • Updated the "active," "selected," "disabled," and "disabledBackground" states to enhance visibility when components are placed on the "grey.900" background, commonly used in navigation bars and code app's heading and drawer.

Note:
Replaced the colors with alternatives that maintain the same appearance but with different contrast levels, ensuring visibility in both dark and light themes without altering the overall UI color scheme.

Below are the changes before and after they were applied:

image

@geodem127 geodem127 force-pushed the Update-Theme-Pallete-And-Toggle-Button branch 2 times, most recently from 76a0649 to f6046e6 Compare March 14, 2025 13:09
@geodem127 geodem127 force-pushed the Update-Theme-Pallete-And-Toggle-Button branch from f6046e6 to def63f3 Compare March 14, 2025 13:16
@geodem127 geodem127 requested review from finnar-bin, agalin920 and shrunyan and removed request for finnar-bin March 14, 2025 13:18
@finnar-bin
Copy link
Contributor

@geodem127 what's the reason behind those buttons with a red outline and the text not being readable?
image

@geodem127 geodem127 force-pushed the Update-Theme-Pallete-And-Toggle-Button branch from c19cb4a to 51322c7 Compare March 17, 2025 05:47
@geodem127 geodem127 force-pushed the Update-Theme-Pallete-And-Toggle-Button branch from 51322c7 to ddd2ead Compare March 17, 2025 05:48
@geodem127 geodem127 requested review from finnar-bin March 17, 2025 05:50
@geodem127
Copy link
Contributor Author

Buttons outlined in red are in the action.active, action.selected, or disabled states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants