Skip to content

feat: Add support for ROG MAXIMUS X HERO#89

Merged
zeule merged 2 commits intozeule:masterfrom
reisholmes:feat/maximus_x_hero
Dec 4, 2025
Merged

feat: Add support for ROG MAXIMUS X HERO#89
zeule merged 2 commits intozeule:masterfrom
reisholmes:feat/maximus_x_hero

Conversation

@reisholmes
Copy link
Copy Markdown
Contributor

This commit adds in support for the ROG MAXIMUS X HERO motherboard.

grep -e '' -n /sys/class/dmi/id/board_{name,vendor} to obtain the name:

/sys/class/dmi/id/board_name:1:ROG MAXIMUS X HERO
/sys/class/dmi/id/board_vendor:1:ASUSTeK COMPUTER INC.

Included the dsdt.dat as a zip
dsdt.dat.zip

Build works fine with the commands:

sudo LLVM=true make modules
sudo LLVM=true make dkms_configure
sudo LLVM=true make dkms

Here's the relevant sensors output section after running sudo sensors-detect --auto built on CachyOS 6.17.9.2:

asusec-isa-000a
Adapter: ISA adapter
CPU_Opt:        0 RPM
Chipset:      +47.0°C
CPU:          +37.0°C
Motherboard:  +33.0°C
T_Sensor:     +30.0°C
VRM:           +0.0°C

Note the closed PR: #64
Discussion was raised in there as to why the "Water_Flow, Water_In, Water_Out" sensors have been omitted from this commit (TLDR: They are on a secondary EC we do not currently have the capability of accessing)

I don't have any CPU_OPT currently plugged in but this was previously tested to be working in the above mentioned PR.

This commit adds in support for the ROG MAXIMUS X HERO motherboard
@reisholmes
Copy link
Copy Markdown
Contributor Author

Force pushes were to correct the matching order of the ./scripts/check.sh
It turns out the board_info using lowercase with the underscore sorts ("maximus_x_hero") before the lowercase 'i' so this is correct:

maximus_x_hero
maximus_xi_hero

but the DMI table uses uppercase so the underscore sorts ("MAXIMUS X HERO") after the uppercase I so:

MAXIMUS XI HERO
MAXIMUS XI HERO (WI-FI)
MAXIMUS X HERO

Today I learned 😆

@zeule
Copy link
Copy Markdown
Owner

zeule commented Dec 3, 2025

Please add the board name to the list in README.md

Signed-off-by: reis <4367558+reisholmes@users.noreply.github.com>
@reisholmes
Copy link
Copy Markdown
Contributor Author

Please add the board name to the list in README.md

Completed.

@zeule
Copy link
Copy Markdown
Owner

zeule commented Dec 3, 2025

Oops, sorry, one more thing is missing. Kernel needs a real name and email for the author and Signed-off-by fields. I can copy one to another while submitting the patch, of course. So, please give me your real name and email (not @users.noreply.github.com). If you don't want to share that here, you can send me an email.

@reisholmes
Copy link
Copy Markdown
Contributor Author

reisholmes commented Dec 3, 2025

Oops, sorry, one more thing is missing. Kernel needs a real name and email for the author and Signed-off-by fields. I can copy one to another while submitting the patch, of course. So, please give me your real name and email (not @users.noreply.github.com). If you don't want to share that here, you can send me an email.

Name: Reis Holmes
Email: reisholmes @ pm <dot> me

@zeule zeule merged commit b5c1951 into zeule:master Dec 4, 2025
1 check passed
@zeule
Copy link
Copy Markdown
Owner

zeule commented Dec 4, 2025

Thank you!

@zeule
Copy link
Copy Markdown
Owner

zeule commented Dec 4, 2025

Force pushes were to correct the matching order of the ./scripts/check.sh It turns out the board_info using lowercase with the underscore sorts ("maximus_x_hero") before the lowercase 'i' so this is correct:

maximus_x_hero maximus_xi_hero

but the DMI table uses uppercase so the underscore sorts ("MAXIMUS X HERO") after the uppercase I so:

MAXIMUS XI HERO MAXIMUS XI HERO (WI-FI) MAXIMUS X HERO

Today I learned 😆

I need to change the sorting check 🤔

@zeule zeule added the mainlined The changes are accepted to the mainline kernel label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mainlined The changes are accepted to the mainline kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants