Rework rec #57
Open
Rework rec #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My user doesn't have access to /dev/input/* by default, so I would need
to run "rec" as root -- which, in turn, breaks recording audio, because
root does not have access to my PulseAudio process.
This commit now allows you to do this:
$ sudo cat /dev/input/event123 | ./rec
Amplitude detection didn't work too well for me. :/ rec now keeps 1/32s of history. As soon as we detect a key, that history will be written to the output file. After that, another 1/2s will be recorded to catch all the "zoingggggg" noises. Auto-normalization was a bad idea to begin with. We must find the global peak value of all samples and then normalize all of them using the same gain.
Owner
|
Quoting vain (2017-06-18 10:51:06)
Several improvements (IMHO) to rec. Not sure if you want this. :-)
Hm, not sure either. I usually just fiddle with the tool every time I do
new recordings, so it's never the same. I did find the level detection
appropriate to get all samples properly aligned, since there seems to be
some jitter in the key reporting events and audio latency (on my system,
anyway).
Not merging yet, but just leave this here: we might pick it up later.
…--
:wq
^X^Cy^K^X^C^C^C^C
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements (IMHO) to rec. Not sure if you want this. :-)