Cherrymxbluesounds #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds but the packaging process has not been modified to include the installation of the sounds in their appropriate location
… blue sounds path
Contributor
|
Personally, I really like your suggested sound. However, not sure if most of the code changes are really needed. Isn't |
AlexanderWillner
added a commit
to AlexanderWillner/bucklespring
that referenced
this pull request
Jan 26, 2021
|
I need this chanagessssss, please accept :( |
Owner
|
Hi; sorry for ignoring this for so long. I think development on bucklespring has kind of ceased, apart from the occasional bugfix. There is already the command line option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses different sounds for the keyboard. It introduces the -c option to enable using cherrymxblue sounds, the folder of sounds is located in the root directory, and the path is included in the makefile same as the PATH_AUDIO. The entire keylayout uses the same sounds except for enter, space and shift. This pull request uses the -f option to use the 0x31 key for all keys.