Skip to content

feat(editor): support editing of emails with very long body text #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
May 19, 2025
Merged

feat(editor): support editing of emails with very long body text #890

merged 24 commits into from
May 19, 2025

Conversation

gnekoz
Copy link
Contributor

@gnekoz gnekoz commented May 8, 2025 •
edited
Loading

  • Switched the editor components (both plain text and rich text editors) to the uncontrolled mode
  • Refactored the editors store to handle uncontrolled components via a provider that enable to notify the up to date text content
  • Splitted the TextEditorContainer component in 2 subcomponents, one for the rich text content and one for the plain text content
  • New the editors can handle mails with long body text (MB) 🚀

Important

The Shell fix in zextras/carbonio-shell-ui#610 is required to have the TinyMCE correctly set in uncontrolled mode

Refs: CO-1454

nubsthead and others added 23 commits April 24, 2025 12:42
@nubsthead
feat: uncontrolled mode implementation
489cee9
@gnekoz
refactor(wip): try direct usage of TinyMCE
3f73929
@nubsthead
feat(wip): remove composer from shell
ff58d9f
@nubsthead
feat: debounce save on key down
94e4a67
@gnekoz
refactor: change tinymce listened event
a39643a
@gnekoz
feat: update tinymce from external components
90afdf3
@gnekoz
fix: keep focus on other editor components after save
aebf28b
@gnekoz
refactor(wip): handle tinymce remove event
b65762a
@nubsthead
feat: save draft when the composer is closed
4ddb277
@nubsthead
refactor: memoize setTextProvider
8f14596
@nubsthead
test: refactor text-editor-container tests
36eb57d
@nubsthead
refactor: textarea in uncontrolled mode
3e5dc07
@nubsthead
fix: debounce on composer change
eaa654b
@nubsthead
fix: remove reactive value from useEditorText
38c2e93
@nubsthead
refactor: split text editor components
c341ace
@gnekoz
test: add tests for useEditorTextProvider
4fea20a
@gnekoz
test: complete useEditorTextProvider tests
2966d92
@gnekoz
test: move and extend useEditorText tests
fded5dd
@gnekoz
refactor: avoid useless text save
28f6ab8
@nubsthead
refactor: split text editor components
1651232
@nubsthead
test: update tests
64396f9
@nubsthead
refactor: clean up editor text component props
50e027e
@nubsthead
refactor: clean up editor test component props
7f7317b
@gnekoz gnekoz marked this pull request as ready for review May 9, 2025 13:56
@sonarqube-zextras Sonarqube Zextras
Copy link

Failed Quality Gate failed

  • 58.90% Coverage on New Code (is less than 80.00%)
  • 1 New Issues (is greater than 0)

Project ID: carbonio-mails-ui

View in SonarQube

@gnekoz gnekoz requested review from drazen04 and nubsthead May 16, 2025 15:03
@gnekoz gnekoz merged commit 2c41ccf into devel May 19, 2025
2 of 3 checks passed
@gnekoz gnekoz deleted the CO-1454-uncontrolled-mode-solution branch May 19, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drazen04 drazen04 drazen04 approved these changes

@nubsthead nubsthead nubsthead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnekoz @drazen04 @nubsthead