Skip to content

feat(editor): support editing of emails with very long body text #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 19, 2025

Conversation

gnekoz
Copy link
Contributor

@gnekoz gnekoz commented May 8, 2025

  • Switched the editor components (both plain text and rich text editors) to the uncontrolled mode
  • Refactored the editors store to handle uncontrolled components via a provider that enable to notify the up to date text content
  • Splitted the TextEditorContainer component in 2 subcomponents, one for the rich text content and one for the plain text content
  • New the editors can handle mails with long body text (MB) 🚀

Important

The Shell fix in zextras/carbonio-shell-ui#610 is required to have the TinyMCE correctly set in uncontrolled mode

Refs: CO-1454

@gnekoz gnekoz marked this pull request as ready for review May 9, 2025 13:56
Copy link

Failed Quality Gate failed

  • 58.90% Coverage on New Code (is less than 80.00%)
  • 1 New Issues (is greater than 0)

Project ID: carbonio-mails-ui

View in SonarQube

@gnekoz gnekoz requested review from drazen04 and nubsthead May 16, 2025 15:03
@gnekoz gnekoz merged commit 2c41ccf into devel May 19, 2025
2 of 3 checks passed
@gnekoz gnekoz deleted the CO-1454-uncontrolled-mode-solution branch May 19, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants