Skip to content

fix: improve context menu prevention logic #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

fix: improve context menu prevention logic #609

merged 1 commit into from
May 13, 2025

Conversation

keshavbhatt
Copy link
Member

@keshavbhatt keshavbhatt commented May 9, 2025 •
edited
Loading

Refs: CO-2083

What was changed:

  • Updated the context menu event listener to traverse event.composedPath() and check for allowed elements anywhere in the event path, enabling proper behavior even when right-clicking inside Shadow DOM elements.
  • Documented expected behavior with tests

@keshavbhatt
fix: improve context menu prevention logic for specific elements
92f5a26 
update the listener to traverse `event.composedPath()`
and check for allowed checks anywhere in the hierarchy
@keshavbhatt keshavbhatt changed the title fix: improve context menu prevention logic for specific elements fix: improve context menu prevention logic May 9, 2025
@CLAassistant
Copy link

CLAassistant commented May 9, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sonarqube-zextras Sonarqube Zextras
Copy link

Passed Quality Gate passed

Issues

Measures

Project ID: carbonio-shell-ui

View in SonarQube

@keshavbhatt keshavbhatt marked this pull request as ready for review May 9, 2025 16:00
@keshavbhatt keshavbhatt merged commit a6c9c48 into devel May 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frisonisland frisonisland frisonisland approved these changes

@FrancescoGottardi FrancescoGottardi FrancescoGottardi approved these changes

@giuliano176 giuliano176 giuliano176 approved these changes

@CataldoMazzilli CataldoMazzilli Awaiting requested review from CataldoMazzilli

@gnekoz gnekoz Awaiting requested review from gnekoz

@lisaparma lisaparma Awaiting requested review from lisaparma

@CerDennis CerDennis Awaiting requested review from CerDennis

@nubsthead nubsthead Awaiting requested review from nubsthead

@yukiLu6 yukiLu6 Awaiting requested review from yukiLu6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keshavbhatt @CLAassistant @frisonisland @FrancescoGottardi @giuliano176