Skip to content

Add Acknowledgment To the Team mates#20

Merged
zhaochenyang20 merged 2 commits intomainfrom
update_doc
Feb 23, 2026
Merged

Add Acknowledgment To the Team mates#20
zhaochenyang20 merged 2 commits intomainfrom
update_doc

Conversation

@zhaochenyang20
Copy link
Copy Markdown
Owner

Make readme professional.

@zhaochenyang20 zhaochenyang20 merged commit 1c50a0f into main Feb 23, 2026
1 check passed
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @zhaochenyang20, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the README.md to provide a more professional and informative overview of the SGLang Diffusion Router. The changes aim to improve user understanding of the router's capabilities and how to interact with its API, while also formally acknowledging the contributing team members.

Highlights

  • Documentation Enhancement: The README.md has been significantly updated to improve clarity and professionalism, including a new project title and an expanded description.
  • API Reference Integration: A comprehensive "API Reference" section has been introduced, detailing all available router endpoints and their functionalities, replacing a less detailed "Highlights" section.
  • Example Restructuring: The usage examples have been reorganized and expanded, now featuring dedicated "With Python Requests" and "With Curl" sections, including a new example for updating weights from disk.
  • Team Acknowledgment: A detailed list of team members has been added to the "Acknowledgment" section, recognizing contributions to the project.
Changelog
  • README.md
    • Updated the project title and description for better clarity.
    • Replaced the "Highlights" section with a detailed "API Reference" for all endpoints.
    • Streamlined the "Quick Start" guide by removing redundant router startup instructions.
    • Reorganized and expanded usage examples into "Demonstrative Examples" with Python and Curl sections.
    • Removed the "Router API" and "Project Layout" sections, integrating relevant information elsewhere.
    • Enhanced the "Acknowledgment" section by adding a comprehensive list of team members.
    • Removed the "Notes" section.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request improves the README by adding a comprehensive API reference and acknowledging the development team. The reorganization makes the documentation more concise. I have suggested a few minor grammatical and spelling corrections to enhance the professionalism of the document.

Comment thread README.md
A lightweight router for SGLang diffusion workers used in RL systems.

It provides worker registration, load balancing, health checking, and request proxying for diffusion generation APIs.
It provides worker registration, load balancing, health checking, refit weights and request proxying for diffusion generation APIs.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The list of features uses gerunds (registration, balancing, checking, proxying). To maintain parallel structure and grammatical consistency, 'refit weights' should be changed to 'weight refitting'. Additionally, the Oxford comma used in the previous version should be restored for consistency.

Suggested change
It provides worker registration, load balancing, health checking, refit weights and request proxying for diffusion generation APIs.
It provides worker registration, load balancing, health checking, weight refitting, and request proxying for diffusion generation APIs.

Comment thread README.md
This project is derived from [radixark/miles#544](https://github.com/radixark/miles/pull/544). Thanks to the original authors.

## Notes
SGLang Diffusion RL team is responsible for the development and maintenance of this project. Our team mates in alphabetical order:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

'team mates' is typically written as a single word: 'teammates'.

Suggested change
SGLang Diffusion RL team is responsible for the development and maintenance of this project. Our team mates in alphabetical order:
SGLang Diffusion RL team is responsible for the development and maintenance of this project. Our teammates in alphabetical order:

@zhaochenyang20 zhaochenyang20 deleted the update_doc branch February 23, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant