-
Notifications
You must be signed in to change notification settings - Fork 6
[WIP] ci: add more testcase #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zhaochenyang20
merged 3 commits into
zhaochenyang20:main
from
alphabetc1:ci/add_more_testcase
Feb 23, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: PR Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [main] | ||
|
|
||
| jobs: | ||
| pr-test: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.12" | ||
|
|
||
| - name: Install package and test deps | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| python -m pip install -e . | ||
| python -m pip install pytest | ||
|
|
||
| - name: Run CPU-only tests | ||
| run: pytest tests/unit -v |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,6 +69,16 @@ def _setup_routes(self) -> None: | |
| ) | ||
|
|
||
| async def _start_background_health_check(self) -> None: | ||
| # Probe video capability for pre-registered workers in the running event loop. | ||
| unknown_workers = [ | ||
| url for url, support in self.worker_video_support.items() if support is None | ||
| ] | ||
| if unknown_workers: | ||
| await asyncio.gather( | ||
| *(self.refresh_worker_video_support(url) for url in unknown_workers), | ||
| return_exceptions=True, | ||
| ) | ||
|
Comment on lines
+72
to
+80
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| if self._health_task is None or self._health_task.done(): | ||
| self._health_task = asyncio.create_task(self._health_check_loop()) | ||
|
|
||
|
|
@@ -383,6 +393,12 @@ async def generate(self, request: Request): | |
|
|
||
| async def generate_video(self, request: Request): | ||
| """Route video generation to /v1/videos.""" | ||
| if not self.worker_request_counts: | ||
| return JSONResponse( | ||
| status_code=503, | ||
| content={"error": "No workers registered in the pool"}, | ||
| ) | ||
|
Comment on lines
+396
to
+400
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| candidate_workers = [ | ||
| worker_url | ||
| for worker_url, support in self.worker_video_support.items() | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| """Pytest configuration: force local src import precedence.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import sys | ||
| from pathlib import Path | ||
|
|
||
| src_str = str(Path(__file__).resolve().parent.parent / "src") | ||
| while src_str in sys.path: | ||
| sys.path.remove(src_str) | ||
| sys.path.insert(0, src_str) |
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of the
refresh_taskslist and the_refresh_all_worker_video_supportasync function simplifies the router startup logic in_run_router_server. This logic has been correctly moved to the_start_background_health_checkmethod indiffusion_router.py.