Revert "[WIP] ci: add more testcase"

[zhaochenyang20]

Reverts #25

[gemini-code-assist]

Summary of Changes

Hello @zhaochenyang20, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily reverts a previous commit that introduced additional test cases. It also refactors the router initialization process to handle worker video support asynchronously. The changes streamline the testing process and adjust the router's worker management.

Highlights

• Reversion: This PR reverts a previous commit that added more test cases, effectively undoing those changes.
• Test Configuration: The end-to-end tests and associated configurations have been removed, focusing the test suite on unit tests only.
• Router Initialization: The router server initialization logic was modified to refresh worker video support asynchronously.

Changelog

• development.md
  • Removed instructions for running real E2E tests, simplifying the testing documentation.
• pyproject.toml
  • Updated pytest configuration to only include unit tests, excluding end-to-end tests.
• src/sglang_diffusion_routing/cli/main.py
  • Added asyncio import and modified the router server to refresh worker video support asynchronously during startup.
• src/sglang_diffusion_routing/router/diffusion_router.py
  • Removed probing video capability for pre-registered workers during background health check and removed a check for worker request counts before routing video generation requests.
• tests/conftest.py
  • Removed the conftest.py file.
• tests/e2e/test_e2e_sglang.py
  • Removed the end-to-end test file.
• tests/unit/fake_worker.py
  • Removed the fake worker file.
• tests/unit/test_cli.py
  • Modified CLI tests to remove timeout arguments and add a test for calling the router runner.
• tests/unit/test_diffusion_router.py
  • Refactored unit tests for DiffusionRouter, improving test structure and adding regression tests.
• tests/unit/test_fake_e2e.py
  • Removed the fake end-to-end test file.
• tests/unit/test_router_endpoints.py
  • Added a new test file for router endpoints.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/pr-test.yml

Activity

• The pull request reverts commit [WIP] ci: add more testcase #25.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily reverts previous changes related to adding more test cases, specifically removing end-to-end tests and their associated infrastructure. It also includes some refactoring in the CLI and router logic, such as moving the worker video support probing to the CLI startup and improving test organization. While the revert itself is straightforward, some of the refactoring has led to a reduction in test coverage for core router functionalities and CLI argument parsing. It's important to restore this coverage to ensure the stability and correctness of the application.

I am having trouble creating individual review comments. Click here to see my feedback.

tests/unit/test_diffusion_router.py (156-296)

The removal of several test classes (TestRegisterWorker, TestBuildProxyResponse, TestSanitizeResponseHeaders, TestTryDecodeJson, TestConstructor) from this file results in a critical loss of unit test coverage for core DiffusionRouter functionalities. While some worker registration tests were moved to test_router_endpoints.py, crucial aspects like _build_proxy_response (JSON handling, status code preservation), _sanitize_response_headers, _try_decode_json, and various constructor behaviors (e.g., timeout defaults, route registration) are no longer explicitly tested. This significantly increases the risk of regressions. Please ensure that all previously covered functionalities are adequately tested, either by restoring these tests or by adding equivalent coverage in other test files.

tests/unit/test_cli.py (40-47)

The removal of these arguments from the test_parses_worker_urls (formerly test_full_args) method reduces test coverage for the CLI argument parsing. While test_defaults covers default values, this test was responsible for verifying that non-default values for --timeout, --max-connections, --health-check-interval, and --health-check-failure-threshold are correctly parsed. This is a regression in test coverage that should be addressed.

tests/unit/test_cli.py (57-66)

The removal of assertions for args.timeout and the tests for test_rejects_invalid_routing_algorithm and test_accepts_all_valid_algorithms represents a significant loss of test coverage for CLI argument parsing and validation. It's crucial to ensure that the CLI correctly handles these parameters and validates routing algorithms. Please restore these tests to prevent potential regressions.