Skip to content

[diffusion] chore: update sglang submodule to include width/height fix#39

Merged
alphabetc1 merged 1 commit intozhaochenyang20:mainfrom
Ratish1:fix/update-sglang-submodule-dimensions
Mar 9, 2026
Merged

[diffusion] chore: update sglang submodule to include width/height fix#39
alphabetc1 merged 1 commit intozhaochenyang20:mainfrom
Ratish1:fix/update-sglang-submodule-dimensions

Conversation

@Ratish1
Copy link
Copy Markdown
Contributor

@Ratish1 Ratish1 commented Mar 8, 2026

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

  • Format your code with pre-commit run --all-files.
  • Add or update unit tests if applicable.
  • Update documentation if applicable.
  • Provide accuracy and performance benchmark results if applicable.
  • Ensure all CI checks pass.

Review Process

  1. Get approvals from maintainers and other reviewers.
  2. Ensure all CI tests pass.
  3. After green CI and required approvals, ask maintainers to merge.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on integrating a crucial fix into the project by updating the sglang submodule. The change ensures that the application benefits from the latest improvements and bug fixes from this dependency, specifically addressing a width/height issue.

Highlights

  • sglang Submodule Update: The sglang Git submodule has been updated to commit b94fc6b065f85ea721fece59b51b32d8e2905aa6. This update is intended to incorporate a width/height fix into the project.
Changelog
  • sglang
    • Updated the sglang submodule to a newer commit.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the sglang submodule, which, according to the title, incorporates a fix for width/height handling. The change itself is a standard submodule pointer update. My review suggests adding an end-to-end test to verify that the width/height fix from the submodule is working as expected within this project's environment. This will improve the robustness of the change and help prevent future regressions.

@zhaochenyang20
Copy link
Copy Markdown
Owner

could @alphabetc1 help to check this?

@alphabetc1
Copy link
Copy Markdown
Collaborator

alphabetc1 commented Mar 9, 2026

before this fix(~70GB leftover mem):
image

after this fix(mem dropped from ~70GB to ~62GB, still 3GB higher than others and needs more investigation):
Image

@alphabetc1 alphabetc1 merged commit 05ea250 into zhaochenyang20:main Mar 9, 2026
2 checks passed
@Ratish1 Ratish1 deleted the fix/update-sglang-submodule-dimensions branch March 9, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants