Skip to content

feature: add i18n support on distance and length text with "pt" language #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

victorvuelma
Copy link
Contributor

@victorvuelma victorvuelma commented Mar 19, 2021

Add i18n support on distance and length text, with pt language

@thexs-dev
Copy link

Is there a way to remove the texts from this message altogether?
Like instead of
Total distance: ${lenght}; Total area: ${area}.
Just use
${lenght}; ${area}

It gets extra space on the map and it becomes redundant after the first time you read it

@victorvuelma
Copy link
Contributor Author

Is there a way to remove the texts from this message altogether?
Like instead of
Total distance: ${lenght}; Total area: ${area}.
Just use
${lenght}; ${area}

It gets extra space on the map and it becomes redundant after the first time you read it

Can be added a flag to use "short description" of area and length.

@victorvuelma
Copy link
Contributor Author

@zhenyanghua

Can you check this?

Copy link
Owner

@zhenyanghua zhenyanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Victor, Thanks for the contribution. I like your idea there. Left one more thing to address it will be good to go.

@victorvuelma
Copy link
Contributor Author

@zhenyanghua

Hello Zhenyang, i have added fallback to english if specified property was not found on current language, sounds good?

@victorvuelma victorvuelma requested a review from zhenyanghua May 4, 2021 14:24
@TaxiPilot
Copy link

TaxiPilot commented Apr 4, 2022

Hi
in your i18n.js there is the list of languages: when I choose 'it', it works, but when I opt for the 'uk' language, it doesn't work (the default 'en' language). When type in console measureTool._options.language - return 'uk' value .... help please
P.S. Thanks for your work!

@victorvuelma
Copy link
Contributor Author

@zhenyanghua

Hello! Could you validate the changes you made to make this update available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants