Update SeqClassification.cs #94
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Showing the probabilities of an answer
zhongkaifu
approved these changes
Dec 1, 2024
Owner
zhongkaifu
left a comment
zhongkaifu
left a comment
There was a problem hiding this comment.
Sorry for my delayed review. It looks good to me. Thank you for this update.
zhongkaifu
reviewed
Dec 2, 2024
| // Fetch the corresponding probability for the predicted target index | ||
| float probAtTargetIdx = probs.GetWeightAt([0, (long)targetIdx[k]]); | ||
|
|
||
| nr.Output[0][k].Add($"{targetWords[k]} {probAtTargetIdx:F8}"); |
Owner
There was a problem hiding this comment.
Maybe you could add a new field for probability at target idx, such as:
public List<List<List>> Output; // (beam_size, batch_size, seq_len)
public List<List<List>> ProbAtOutputIdx; // (beam_size, batch_size, seq_len)
Contributor
Author
There was a problem hiding this comment.
Yes, I figured you would have a good idea on adding something. I'll see about adding it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing the probabilities of an answer. I find it useful. What do you think?