Fixed incorrect package name in panic exercise which caused go vet error in CI - #169
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughRenames and small refactors across exercise templates: one test package renamed, several time-delay template functions renamed to their final exported names (implementations remain TODO), removal of an unused sync import/WaitGroup, and a relaxed timing assertion in a worker-pools test. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant TimeDelay as timedelay (package)
rect rgb(230, 248, 230)
Note right of TimeDelay: API surface (renamed functions)
end
Caller->>TimeDelay: WaitFor(ms)
Caller->>TimeDelay: NotifyAfter(ms) --> returns chan bool
Caller->>TimeDelay: NotifyAt(target) --> returns chan bool
Caller->>TimeDelay: ScheduleAfter(ms, fn) --> returns chan struct{}
Note over Caller,TimeDelay: Implementations are TODO (signatures changed only)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixed function names in timedelay
…max of 1400 microseconds
Summary
As described in the title.
Checklist
make verifyorgolearn verify <slug>Summary by CodeRabbit
Refactor
Bug Fixes
Note: No user-facing features added; changes are internal and aim to improve code structure and test stability.