Make rotating of cards customizable #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing! 😄 reviewing your PR right now |
AndrewSB
requested changes
Sep 29, 2016
| @@ -11,9 +11,9 @@ Pod::Spec.new do |s| | |||
| s.author = { "Zhixuan Lai" => "[email protected]" } | |||
| s.social_media_url = "http://twitter.com/ZhixuanLai" | |||
|
|
|||
| s.platform = :ios, "8.0" | |||
| s.platform = :ios, "9.0" | |||
There was a problem hiding this comment.
is there a reason this change to drop support for iOS 8?
| @@ -56,15 +56,18 @@ class ViewManager : NSObject { | |||
| private let containerView: UIView | |||
| private let miscContainerView: UIView | |||
| private let animator: UIDynamicAnimator | |||
| private let rotatingSpeedMultiplyer: CGFloat | |||
There was a problem hiding this comment.
this should be rotatingSpeedMultiplier
| self.view = view | ||
| self.containerView = containerView | ||
| self.miscContainerView = miscContainerView | ||
| self.animator = animator | ||
| self.swipeableView = swipeableView | ||
| self.state = ViewManager.defaultSnappingState(view) | ||
| self.rotatingSpeedMultiplyer = rotMul |
There was a problem hiding this comment.
here as well, Multiplyer should be spelt Multiplier 👍
There was a problem hiding this comment.
and anywhere else in the file where you've used or defined a variable with that in it's name
|
@ilyavelilyaev can you also explain what kind of rotation this affects? Is it the rotation that takes place when you drag to the left or right? |
added 2 commits
November 23, 2016 23:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now rotating of cards seems to be to fast. Added property, which can adjust the desirable speed.