Metrics: isolate protobuf dependency
#14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inge4pres
force-pushed
the
isolate-protobuf
branch
2 times, most recently
from
855f683 to
dca029d
Compare
inge4pres
force-pushed
the
isolate-protobuf
branch
from
dca029d to
5146049
Compare
Avoid pre-aggregating values, keep all the scalars and their attributes as they are recorded by the instruments. Aggregation should occur when collecting. Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
@fixme: union field access violation reported in tests, introduced in this commit Signed-off-by: inge4pres <[email protected]>
@fixme: memory leak in reader/exporter tests Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]> Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
inge4pres
force-pushed
the
isolate-protobuf
branch
from
5146049 to
957feaa
Compare
|
Rebased and amended examples accordingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Part of #11
Details
This is a rather big PR, where the commit history might help reviewing 🙏🏼
It is a big change because so far, all the interactions across multiple components were happening through protobuf-generated types.
With this PR, we introduce smaller and easier to use types, that are also easier to move around.
There's also a semantic change in metrics collection that is more in-line with the OTel philosophy: metrics' data points are never aggregated by the instruments, but only at collection time.
This is a small memory footprint increase traded for more accuracy and modularity in the metrics exporting.