-
Notifications
You must be signed in to change notification settings - Fork 5
Fix #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+59
−3
Closed
Fix #22
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
12e4d70
Merge pull request #1 from mstdokumaci/main
mstdokumaci 779ffa2
fix(clonePayload): improve error handling for partial cloning of arra…
mstdokumaci f56062e
chore: apply code review changes
mstdokumaci 2f87d92
fix(clonePayload): simplify error handling in clonePayload function
mstdokumaci 731baa2
lint
mstdokumaci 79943da
chore: apply suggested fixes
mstdokumaci e7843ed
chore: apply suggested fixes
mstdokumaci File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test may not be sufficient to detect the double-free issue present in the
clonePayloadimplementation for maps. Thestd.heap.FixedBufferAllocatordoes not detect double-frees, so it's possible for the double-free to occur without causing the subsequent allocation to fail, leading to a false positive test result.To reliably catch this kind of memory safety issue, you would typically need to run tests with an allocator that has double-free detection or use tools like the address sanitizer (
-fsanitize=address).