This repository was archived by the owner on Nov 26, 2025. It is now read-only.
Fix alignment attributes not being emitted for arrays if the total size matched the alignment - #199
Merged
Merged
Conversation
…instead of looking at the total field size. Previously, if the field size (in this case of the entire array) happened to match the requested alignment, then the alignment attribute was not emitted.
kcbanner
force-pushed
the
fixup_alignment
branch
from
October 7, 2025 17:18
53be774 to
a7f5ea0
Compare
Vexu
enabled auto-merge (rebase)
October 7, 2025 19:10
This was referenced Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
headFieldAlignmentandalignmentForFieldto usealignofinstead of looking at the total field size.Previously, if the field size (in this case of the entire array) happened to match the requested alignment, then the alignment attribute was not emitted.